Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: prevent table start-ts regressions (#1236) #1352

Merged

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jan 27, 2021

What problem does this PR solve?

What is changed and how it works?

  • Fixed several bugs in Owner so that never will a local checkpoint be less than the global checkpoint.
  • Cleaned up checkpoint ts semantics with respect to DDL operations, so that a DDL is finished if and only if global checkpoint >= FinishTs.
  • Fixed a bug in processor introduced by *: fix the output in changefeed out of order #1247 which causes local checkpoint regression.
  • Added Etcd state checker to integration test.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix bugs in the owner that could lead to abnormal CDC server exits during table migrations.

@liuzix liuzix added status/ptal Could you please take a look? type/bugfix This PR fixes a bug. component/replica-model Replication model component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Jan 27, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jan 27, 2021

/run-all-tests

@amyangfei amyangfei added type/4.0-cherry-pick and removed needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Jan 27, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jan 27, 2021

/run-all-tests

@liuzix liuzix requested a review from amyangfei January 27, 2021 07:33
@liuzix
Copy link
Contributor Author

liuzix commented Jan 27, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Jan 27, 2021

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-4.0@5d2f83c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-4.0      #1352   +/-   ##
================================================
  Coverage               ?   47.5397%           
================================================
  Files                  ?        130           
  Lines                  ?      13149           
  Branches               ?          0           
================================================
  Hits                   ?       6251           
  Misses                 ?       6225           
  Partials               ?        673           

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 1361
  • 1344
  • 1342

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@liuzix merge failed.

@liuzix
Copy link
Contributor Author

liuzix commented Jan 27, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@liuzix merge failed.

@liuzix
Copy link
Contributor Author

liuzix commented Jan 27, 2021

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 1361
  • 1344

@ti-srebot
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/replica-model Replication model component. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants